Acked-by: Gert Doering <[email protected]>
Subjected to the full set of server side tests that so nicely crashed
11/25 v2 :-) (passed) and to client Linux/FreeBSD t_client tests including
P2P NCP (passes as well).
The code looks good, and more correct as well. Thanks for all the
comments and for renaming the function - if it helps my brain, future
contributors might benefit from it as well.
Just for reference: do_deferred_p2p_ncp() is all "part2" type stuff,
so it gets moved as a whole, not split.
NOTE: there is a small change in behaviour, which I'm not sure if
problematic or not. The "part2" behaviour was previously encapsulated
in
if (c->options.pull)
{
...
}
and is no longer checking this in "_part2()".
This makes (as far as I can see) a difference if and only if a client
*without* --pull (-> c->options.pull) will receive a PUSH_REPLY from
a server that is behaving different from what we do - we only send
PUSH_REPLY in reply to a PUSH_REQUEST, or to IV_PROTO=IV_PROTO_REQUEST_PUSH
(and that is only happening if --pull / --client is set on the client).
In the server instance - which is called from multi.c - this would
make a difference *if* we called _part2() from multi.c - but we do not(!),
as that code path calls multi_client_generate_tls_keys(), which does
the tls_session_update_crypto_params() for us... so, server would
not call it before (!options.pull) and doesn't call it now (no call
to _part2()) -> no change here.
Your patch has been applied to the master branch.
commit 6b9f4d71d859c27a9a71699aa899c9a2c5c3b680
Author: Antonio Quartulli
Date: Wed Aug 3 11:50:12 2022 +0200
dco: split option parsing routines
Signed-off-by: Antonio Quartulli <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg24789.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
