Hi,

On Thu, Aug 11, 2022 at 07:00:25PM +0200, Arne Schwabe wrote:
> > I???ve pushed a fix for this panic in 
> > fd6b3bede5a5c210f327e5c9bd3e415ee905048b.
> > I simply didn???t think that user space might give us a non-UDP socket, so 
> > checking for that and rejecting the peer in that case fixes the panic. 
> > Thanks for finding that.
> 
> You should probably also modify the check for dco incompatible in 
> OpenVPN so that using TCP disables DCO on FreeBSD.

Indeed.  One of the next patches will bring "per platform options check",
which would be a good place for the #ifdef TARGET_FREEBSD bits.

I'll see that I can pick part of that patch and apply it tomorrow
(the patch as posted refers to symbols that are brought in by the
"main" win-dco patch, but half of it should apply & make sense as is)

gert

-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to