Hi, On Thu, Aug 18, 2022 at 11:26:38AM +0200, Antonio Quartulli wrote: > -#if defined(TARGET_LINUX) || defined(TARGET_FREEBSD) > - o->tuntap_options.disable_dco = !dco_check_option_conflict(D_DCO, o) > - || > !dco_check_startup_option_conflict(D_DCO, o); > -#endif > + o->tuntap_options.disable_dco = > !dco_check_option_conflict(DCO_CHECK_OPTION_LEVEL, o) > + || > !dco_check_startup_option_conflict(DCO_CHECK_OPTION_LEVEL, o);
Nah, this is not good.
This reads as "this is code which will always return, and will log with
some arbitrary log level" (how would a reader know that D_DCO and
DCO_CHECK_OPTION_LEVEL is not both coming from errror.h?).
Make it explicit, and explain why.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
