Hi,
I remember someone was explaining to me the necessity of verbose
commit messages.
Chi può essere?
> It seems to take an existing setup that builds an installer *with* DCO,
> and remove the DCO bits?
> ... so maybe we can have a better commit message that explains this?
We decided to move the uapi header to the openvpn repo, so no need
anymore to clone driver repo to get that header. Hence this change.
> > - name: configure OpenVPN
> > - run: PKG_CONFIG_PATH=${HOME}/mingw/opt/lib/pkgconfig
> > DCO_SOURCEDIR=$(realpath ../ovpn-dco-win) LDFLAGS=-L$HOME/mingw/opt/lib
> > CFLAGS=-I$HOME/mingw/opt/include OPENSSL_LIBS="-L${HOME}/opt/lib -lssl
> > -lcrypto" OPENSSL_CFLAGS=-I$HOME/mingw/opt/include PREFIX=$HOME/mingw/opt
> > LZO_CFLAGS=-I$HOME/mingw/opt/include LZO_LIBS="-L${HOME}/mingw/opt/lib
> > -llzo2" ./configure --host=${CHOST} --disable-lz4 --enable-dco
> > + run: PKG_CONFIG_PATH=${HOME}/mingw/opt/lib/pkgconfig
> > LDFLAGS=-L$HOME/mingw/opt/lib CFLAGS=-I$HOME/mingw/opt/include
> > OPENSSL_LIBS="-L${HOME}/opt/lib -lssl -lcrypto"
> > OPENSSL_CFLAGS=-I$HOME/mingw/opt/include PREFIX=$HOME/mingw/opt
> > LZO_CFLAGS=-I$HOME/mingw/opt/include LZO_LIBS="-L${HOME}/mingw/opt/lib
> > -llzo2" ./configure --host=${CHOST} --disable-lz4
> > working-directory: openvpn
>
> This, I think, is clear - "--enable-dco is default for windows builds",
> and maybe also "no DCO_SOURCEDIR neccesary anymore, since ovpn_dco_win.h
> is now part of our tree", right?
Yep.
-Lev
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
