On Tue, Oct 11, 2022 at 03:07:04PM +0200, Heiko Hund wrote: > On Montag, 27. Juni 2022 10:36:02 CEST Frank Lichtenheld wrote: > > As mentioned this is true for the specific options configured above. > > But you can easily also get different values out of this function by > > changing the options because frame_calculate_payload overhead does > > not always return the same value. > > I don't get it. It produces the same output for the same input reliably. Do > you want to see a test which forces something different to 1420 by modifying > the inputs accordingly?
Yes, I would like to know (i.e. having the correct behavior being documented by a test) what should happen if options->ce.fragment is set, or options->comp.alg. Because in the code comments it sounds like this will *always* produce 1420, and I don't actually believed that that is true (although I do not remember whether I actually tested this or just read the code). Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
