Hi,

On Mon, Aug 01, 2022 at 02:34:01PM +0200, Arne Schwabe wrote:
> +
> +Tun MTU can be pushed
> +    As part of changing the ``--tun-mtu`` default to 1420 (see below), the
> +    client can now also dynamically configure its MTU and the server will
> +    try to push the client MTU when the client supports it. The directive
> +    ``--tun-mtu-max`` has been introduced to specify the maximum pushable
> +    MTU size.

This text needs rewording, as the default isn't changed.

I can do this on the fly, but I'm not sure what to write here - maybe

> +Tun MTU can be pushed
> +    Clients can now also dynamically configure their MTU and the server will
> +    try to push the ``--tun-mtu`` the client should use when the client
> +    supports it. The directive ``--tun-mtu-max`` has been introduced to 
> +    specify the maximum pushable MTU size.


>          struct tls_session *session = &c->c2.tls_multi->session[TM_ACTIVE];
> +        if (!check_session_cipher(session, &c->options))
> +        {
> +            /* The update_session_cipher method will already print an error 
> */
> +            return false;
> +        }
> +
> +        /* Cipher is considered safe, so we can use it to calculate the max
> +         * MTU size */

I'm not sure I understand that comment, and the introducion of 
check_session_cipher() above...  where's the cipher used for the MTU
calculation below?

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to