Hi,

On Fri, Nov 25, 2022 at 04:53:41PM +0100, Kristof Provost via Openvpn-devel 
wrote:
> Also remove the FreeBSD dco_do_write() implementation, as this function
> will never be called any more on FreeBSD. Assert this.
[..]
> +     * called. See should_use_dco_socket(). */
> +    assert(false);
> +    return -EINVAL;

The patch works fine (tested on the FreeBSD 14 "current of a few weeks
ago" server rig), *but* the coding police says that we need to have
an "ASSERT(0)" here (uppercase)...

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to