Acked-by: Gert Doering <[email protected]>
Straightforward enough :-) - we discussed this at the hackathon today,
and FreeBSD DCO does not "consume" the socket, it just hooks into it and
takes out "interesting" packet - so normal userland operation is still
possible. Support for "floating client control message" is still missing,
but that's shared with Linux DCO (and we'll see an API show up soonish).
Tested (v1) on FreeBSD 14 "-CURRENT a few weeks old", and unsurprisingly,
everything still works fine. v2 only differs in assert(false) vs. ASSERT(0),
so not tested again.
TODO on me: actually come up with an automated test case for float clients.
Your patch has been applied to the master branch.
commit 4cf58f4920b430481b772e5f9e9877f9686d3995
Author: Kristof Provost
Date: Sat Nov 26 10:08:51 2022 +0100
dco: pass control packets through the socket on FreeBSD
Signed-off-by: Kristof Provost <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg25542.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
