Hi,
On Tue, Nov 01, 2022 at 11:21:40AM +0200, Lev Stipakov wrote:
> > @@ -1190,7 +1190,7 @@ link_socket_write(struct link_socket *sock,
> > struct buffer *buf,
> > struct link_socket_actual *to)
> > {
> > - if (proto_is_udp(sock->info.proto) || sock->info.dco_installed)
> > + if (proto_is_udp(sock->info.proto) || to->dco_installed)
> > {
>
> Previously we used to check the dco flag from sock->info and now it is changed
> to "to", which is a separate member in c->c2 (c->c2.to_link_addr vs
> c->c2.link_socket).
>
> Why not use "sock->info.lsa->actual.dco_installed" ? My understanding
> is that this patch
> only moves the flag to a different place and is not supposed to change
> the behavior.
For the sake of the archives: I asked Arne today, and the reply
was "this is not pretty, but with Antonio's upcoming changes to DCO,
it's likely that the dco_installed field goes away, or is reworked
significantly".
So for now, we leave it as it is, knowing it's working but not perfect.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
