We really shouldn't let patches linger for so long... the options.h hunk
had context that now looks completely different, both up and down...

Looking at the code, I do wonder why we increase the unsuccessful_attempts
by the number of entries *skipped*

-                c->options.unsuccessful_attempts++;
+                c->options.unsuccessful_attempts += advance_count;

.. the rest of the patch looks fine.  Haven't actually tested beyond
"compile / t_client".

Your patch has been applied to the master branch.

commit ec5ffe35a394c44b1ea25b7c10dab7da7d792ef2 (master)
commit 42bfb5b03031de7b46a82bdec4f03dbaa1fc6ecb (release/2.6)
Author: Selva Nair
Date:   Tue Sep 7 18:36:14 2021 -0400

     Allow skipping multple remotes via management interface

     Signed-off-by: Selva Nair <selva.n...@gmail.com>
     Acked-by: Arne Schwabe <a...@rfc2549.org>
     Message-Id: <20210907223614.8574-1-selva.n...@gmail.com>
     Signed-off-by: Gert Doering <g...@greenie.muc.de>

kind regards,

Gert Doering

Openvpn-devel mailing list

Reply via email to