multi_process_incoming_dco() is currently partly processing
messages that were actually discarded. This results in a bogus
message being printed:
"Received packet for peer-id unknown to OpenVPN: -1, type 0, reason 2"
Change the flow so that we bail out immediately when we know that no
message was truly delivered by DCO.
Currently this can be verified by chacking that the peed_is is greater
than -1.
Signed-off-by: Antonio Quartulli <a...@unstable.cc>
---
src/openvpn/multi.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
index 27676de5..b10a6d8d 100644
--- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c
@@ -3270,7 +3270,15 @@ multi_process_incoming_dco(struct multi_context *m)
int peer_id = dco->dco_message_peer_id;
- if ((peer_id >= 0) && (peer_id < m->max_clients) &&
(m->instances[peer_id]))
+ /* no peer-specific message delivered -> nothing to process.
+ * bail out right away
+ */
+ if (peer_id < 0)
+ {
+ return ret > 0;
+ }
+
+ if ((peer_id < m->max_clients) && (m->instances[peer_id]))
{
mi = m->instances[peer_id];
if (dco->dco_message_type == OVPN_CMD_PACKET)
--
2.38.2
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
