I've done a bit of stare-at-code, and it's nicely trivial :-) - but let
me repeat what I said on IRC, better coding style would be to do proper
initialization *before* calling dco_do_read(), not as an afterthought
at the end of the function (which also breaks "early return").

I have not tested this patch on its own (just compile-tested), as it's
trivial enough and has an ACK already.

For now this is fine, but we should come back here.

Your patch has been applied to the master branch.

commit e9889016fb7269d025a2dbba5f7079ee87e39520 (master)
commit aaccf88431eb146231a600971227a8a6c395b349 (release/2.6)
Author: Antonio Quartulli
Date:   Tue Jan 3 21:23:28 2023 +0100

     dco: properly re-initialize dco_del_peer_reason

     Signed-off-by: Antonio Quartulli <a...@unstable.cc>
     Acked-by: Arne Schwabe <a...@rfc2549.org>
     Message-Id: <20230103202330.1835-...@unstable.cc>
     Signed-off-by: Gert Doering <g...@greenie.muc.de>

kind regards,

Gert Doering

Openvpn-devel mailing list

Reply via email to