Attention is currently required from: cron2, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email )
Change subject: dco: don't use NetLink to exchange control packets ...................................................................... Patch Set 4: (5 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/28/comment/247c9792_e7b2c3b6 PS4, Line 1702: */ > hmm I'd add a different working because it is not about where to send control > packets, but just chec […] Ack File src/openvpn/ovpn_dco_linux.h: http://gerrit.openvpn.net/c/openvpn/+/28/comment/9b1a1741_9fe75f0a PS4, Line 30: OVPN_CMD_NEW_PEER, > nah, adding a field does not break the API. We can add it later as it fixes a > separate issue. Ack File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/28/comment/f7ee8257_3b07557c PS4, Line 1184: /* unified UDPv4 and UDPv6 and DCO (kernel adds size header) */ > again, why do we talk about size header if this is UDP? when we have TCP we need to add the size header but in the DCO case, the kernel does that for us. http://gerrit.openvpn.net/c/openvpn/+/28/comment/97dc5bba_a14de127 PS4, Line 209: #define SF_DCO_WIN (1<<5) > this is Lev's doing :-D […] Ack http://gerrit.openvpn.net/c/openvpn/+/28/comment/3f58627e_3e6501af PS4, Line 1069: * will strip the length header */ > I am confused. […] Basically in this codepath it is basically more like read_packet_with_header vs read_packet_without_header but we call them udp and tcp here. And therefore use the udp path even for tcp when dco is enabled since that header is already removed. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/28?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia1297c3ae9a28b188ed21ad21ae96fff3d02ee4d Gerrit-Change-Number: 28 Gerrit-PatchSet: 4 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: cron2 Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Thu, 09 Mar 2023 14:32:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <arne-open...@rfc2549.org> Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
