Attention is currently required from: cron2, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email )
Change subject: dco: don't use NetLink to exchange control packets ...................................................................... Patch Set 4: (2 comments) File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/28/comment/6956503d_6dfb58db PS4, Line 1184: /* unified UDPv4 and UDPv6 and DCO (kernel adds size header) */ > when we have TCP we need to add the size header but in the DCO case, the > kernel does that for us. not anymore on linux as packets are just left untouched. http://gerrit.openvpn.net/c/openvpn/+/28/comment/f80fb018_e8c00ace PS4, Line 1069: * will strip the length header */ > Basically in this codepath it is basically more like read_packet_with_header > vs read_packet_without_ […] aaah makes sense now. However, now the length header has to be set/unset by userland, because control packets are left untouched by DCO-linux -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/28?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia1297c3ae9a28b188ed21ad21ae96fff3d02ee4d Gerrit-Change-Number: 28 Gerrit-PatchSet: 4 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 Gerrit-Comment-Date: Thu, 09 Mar 2023 14:37:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <arne-open...@rfc2549.org> Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
