Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/323?usp=email )
Change subject: Add warning if a p2p NCP client connects to a p2mp server ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Patchset: PS1: Looked some more at it, would prefer to move the code. Doesn't change anything about the functionality though. File src/openvpn/ssl_ncp.c: http://gerrit.openvpn.net/c/openvpn/+/323/comment/5b44de9c_0e26824c : PS1, Line 262: /* For client doing the newer version of NCP (that send IV_CIPHER) > Since you have done other drive-by typo fixes, should say "clients" here. Also should be "IV_CIPHERS" http://gerrit.openvpn.net/c/openvpn/+/323/comment/e732bec1_3e5463dc : PS1, Line 270: if (extract_iv_proto(peer_info) & IV_PROTO_NCP_P2P) This function is only called from multi_client_set_protocol_options which already extracts proto and does do various things based on it. I think this code would be better added there instead of here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/323?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I85ae4e1167e1395b4f59d5d0ecf6c38befcaa8a7 Gerrit-Change-Number: 323 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 14 Aug 2023 09:36:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
