Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/323?usp=email )

Change subject: Add warning if a p2p NCP client connects to a p2mp server
......................................................................


Patch Set 2:

(2 comments)

File src/openvpn/ssl_ncp.c:

http://gerrit.openvpn.net/c/openvpn/+/323/comment/6defb60e_c19f4781 :
PS1, Line 262:     /* For client doing the newer version of NCP (that send 
IV_CIPHER)
> Also should be "IV_CIPHERS"
Done


http://gerrit.openvpn.net/c/openvpn/+/323/comment/58e912f0_7db474a0 :
PS1, Line 270:     if (extract_iv_proto(peer_info) & IV_PROTO_NCP_P2P)
> This function is only called from multi_client_set_protocol_options which 
> already extracts proto and […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/323?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I85ae4e1167e1395b4f59d5d0ecf6c38befcaa8a7
Gerrit-Change-Number: 323
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Sun, 08 Oct 2023 09:47:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to