On Sun, 3 Sep 2023 16:47:31 +0200
Antonio Quartulli <a...@unstable.cc> wrote:

> Hi,
> 
> On 03/09/2023 16:29, or...@riseup.net wrote:
> > From: orbea <or...@riseup.net>
> > 
> > Starting with LibreSSL 3.8.1 the engines have been removed which
> > causes the OpenVPN build to fail. This can be solved during
> > configure by checking if OPENSSL_NO_ENGINE is defined in
> > opensslconf.h. ---
> >   configure.ac | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 2f65cbd5..b5a835dc 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -926,11 +926,12 @@ if test "${with_crypto_library}" = "openssl";
> > then AC_COMPILE_IFELSE(
> >                                 [AC_LANG_PROGRAM(
> >                                         [[
> > +       #include <openssl/opensslconf.h>
> >         #include <openssl/opensslv.h>
> >                                         ]],
> >                                         [[
> >         /*       Version encoding: MNNFFPPS - see
> > opensslv.h for details */
> > -       #if OPENSSL_VERSION_NUMBER >= 0x30000000L
> > +       #if OPENSSL_VERSION_NUMBER >= 0x30000000L ||
> > defined(OPENSSL_NO_ENGINE) #error Engine supported disabled by
> > default in OpenSSL 3.0+  
> 
> Maybe the message should be changed now? Or we could have an entirely 
> different message for this case?
> 
> Cheers,
> 
> >         #endif
> >                                         ]]  
> 

Do you think it might be preferable to only check OPENSSL_NO_ENGINE? I
see other code bases such as Tor only checking that define.


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to