Hi, so the v2 patch itself is good, but...
On Sun, Sep 03, 2023 at 09:55:45AM -0700, orbea wrote:
> From d6700ec0f5af2522bb4eb136d3760f5b1445c9d1 Mon Sep 17 00:00:00 2001
> From: orbea <or...@riseup.net>
... it would be really preferred to have a real author name here, and
a "Signed-off-by:" line (git commit -s), and...
> Date: Sat, 2 Sep 2023 23:06:22 -0700
> Subject: [PATCH] configure: disable engines if OPENSSL_NO_ENGINE is defined
>
> Starting with LibreSSL 3.8.1 the engines have been removed which causes
> the OpenVPN build to fail. This can be solved during configure by
> checking if OPENSSL_NO_ENGINE is defined in opensslconf.h.
> ---
[..]
> + /* BoringSSL and LibreSSL >= 3.8.1 removed engine support */
> + #ifdef OPENSSL_NO_ENGINE
> + #error Engine support disabled by default in openssl/opensslconf.h
> #endif
... I think the "by default" needs to go from this #error - it's disabled,
period. "disabled by default" is the OpenSSL 3.0 thing...
(The code change itself looks reasonable, and passes our GHA build
farm with various OSes and mbedTLS / OpenSSL 1.1 / OpenSSL 3.0)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
