Attention is currently required from: stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/327?usp=email )
Change subject: Support for long INFO/INFO_PRE messages ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/327/comment/90da86d9_5dc75b60 : PS1, Line 10: the server (CloudConnexa) sends the longer string in some cases. "sends the longer string" -> "sends longer messages" Patchset: PS1: looks technically okay File src/openvpn/push.c: http://gerrit.openvpn.net/c/openvpn/+/327/comment/cf2407e8_9d3632ee : PS1, Line 246: struct buffer out = alloc_buf_gc(1 + 7 + 1 + BLEN(&buf) + 1, &gc); "1 + 7 + 1" -> strlen(">INFOMSG:") might even move the ">INFOMSG:" into a preprocessor define and then reuse it. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/327?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I2139b62117ba69d643b585d2610e8aef15f71d3e Gerrit-Change-Number: 327 Gerrit-PatchSet: 1 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Mon, 04 Sep 2023 14:39:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
