Attention is currently required from: flichtenheld, stipa.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/327?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by flichtenheld
Change subject: Support for long INFO/INFO_PRE messages
......................................................................
Support for long INFO/INFO_PRE messages
Current hardcoded limit is not defined anywhere and
the server (CloudConnexa) sends the longer string in some cases.
Change-Id: I2139b62117ba69d643b585d2610e8aef15f71d3e
Signed-off-by: Lev Stipakov <l...@openvpn.net>
---
M src/openvpn/push.c
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/27/327/2
diff --git a/src/openvpn/push.c b/src/openvpn/push.c
index d468211..722bfce 100644
--- a/src/openvpn/push.c
+++ b/src/openvpn/push.c
@@ -42,6 +42,8 @@
static char push_reply_cmd[] = "PUSH_REPLY";
+#define INFOMSG_MAN ">INFOMSG:"
+
/*
* Auth username/password
*
@@ -243,8 +245,8 @@
* We use >INFOMSG here instead of plain >INFO since INFO is used to
* for management greeting and we don't want to confuse the client
*/
- struct buffer out = alloc_buf_gc(256, &gc);
- buf_printf(&out, ">%s:%s", "INFOMSG", m);
+ struct buffer out = alloc_buf_gc(strlen(INFOMSG_MAN) + BLEN(&buf),
&gc);
+ buf_printf(&out, "%s%s", INFOMSG_MAN, m);
management_notify_generic(management, BSTR(&out));
gc_free(&gc);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/327?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I2139b62117ba69d643b585d2610e8aef15f71d3e
Gerrit-Change-Number: 327
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-MessageType: newpatchset
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
