Attention is currently required from: MaxF, plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/377?usp=email )

Change subject: Allow specifying custom mbed TLS directories with CMake
......................................................................


Patch Set 4:

(3 comments)

Patchset:

PS4:
Mark comments as done that apply to parts of the change that are not in the 
current version anymore.


File config.h.cmake.in:

http://gerrit.openvpn.net/c/openvpn/+/377/comment/1e8800b8_c7e25722 :
PS1, Line 389: /* we always assume a recent mbed TLS version */
> Outdated comment?
Done


http://gerrit.openvpn.net/c/openvpn/+/377/comment/e0fe93c2_c51086fe :
PS1, Line 390: #cmakedefine HAVE_CTR_DRBG_UPDATE_RET
> In mbed TLS 3, the function mbedtls_ctr_drbg_update_ret does not exist, but 
> mbedtls_ctr_drbg_update  […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/377?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7fd9e730e87210d2b7d090c8f9c7c6734bd7374e
Gerrit-Change-Number: 377
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: MaxF <m...@max-fillinger.net>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: MaxF <m...@max-fillinger.net>
Gerrit-Comment-Date: Tue, 28 Nov 2023 13:33:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Comment-In-Reply-To: MaxF <m...@max-fillinger.net>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to