Attention is currently required from: MaxF, plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/377?usp=email )

Change subject: Allow specifying custom mbed TLS directories with CMake
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/377/comment/aad177a5_630f5dc4 :
PS5, Line 11:
Add a comment here that this also fixes existing issues with mbedTLS support in 
CMake build.


File CMakeLists.txt:

http://gerrit.openvpn.net/c/openvpn/+/377/comment/99fc6c7c_42c8d650 :
PS5, Line 261:         
spurious whitespace


File config.h.cmake.in:

http://gerrit.openvpn.net/c/openvpn/+/377/comment/341beb5a_169b2e4a :
PS5, Line 389: /* we always assume a recent mbed TLS version */
obsolete comment



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/377?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7fd9e730e87210d2b7d090c8f9c7c6734bd7374e
Gerrit-Change-Number: 377
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: MaxF <m...@max-fillinger.net>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: MaxF <m...@max-fillinger.net>
Gerrit-Comment-Date: Thu, 07 Dec 2023 10:41:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to