Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos.
stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters ...................................................................... Patch Set 4: (5 comments) File include/openvpn-msg.h: http://gerrit.openvpn.net/c/openvpn/+/489/comment/b79b7779_628d912d : PS4, Line 27: #include <windef.h> why those are needed here? File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/e376b80f_a07c08de : PS4, Line 621: do_block_local(const struct route_list *rl) since this function doesn't really do any blocking and only check options, maybe rename to "is_block_local_needed()" ? File src/openvpn/wfp_block.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/98a45da8_a4f2c958 : PS4, Line 310: /* Fifth filter. Permit IPv4 for the VPN interface. Permit DNS or all IPv4 traffic for the VPN interface? http://gerrit.openvpn.net/c/openvpn/+/489/comment/d9207c40_fa180f47 : PS4, Line 327: /* Sixth filter. Permit IPv6 for the VPN interface. Same as above - Permit DNS or all IPv6 traffic for the VPN interface? File src/openvpn/win32.h: http://gerrit.openvpn.net/c/openvpn/+/489/comment/55c79df7_1e0f8209 : PS4, Line 28: #include <iphlpapi.h> why those changes? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba Gerrit-Change-Number: 489 Gerrit-PatchSet: 4 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Wed, 10 Jan 2024 10:16:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
