Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters ...................................................................... Patch Set 4: (5 comments) File include/openvpn-msg.h: http://gerrit.openvpn.net/c/openvpn/+/489/comment/8bc08e9f_7c28e168 : PS4, Line 27: #include <windef.h> > why those are needed here? They define some types used in the header. Not that all wouldn't compile without them, but when looking at the single file (like clangd does) these undefinedness. File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/25c045e0_c6d575fc : PS4, Line 621: do_block_local(const struct route_list *rl) > since this function doesn't really do any blocking and only check options, > maybe rename to "is_block […] Done File src/openvpn/wfp_block.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/50237516_00bec708 : PS4, Line 310: /* Fifth filter. Permit IPv4 for the VPN interface. > Permit DNS or all IPv4 traffic for the VPN interface? Done http://gerrit.openvpn.net/c/openvpn/+/489/comment/7e9bc610_f12f2c41 : PS4, Line 327: /* Sixth filter. Permit IPv6 for the VPN interface. > Same as above - Permit DNS or all IPv6 traffic for the VPN interface? Done File src/openvpn/win32.h: http://gerrit.openvpn.net/c/openvpn/+/489/comment/fff56b45_305383c8 : PS4, Line 28: #include <iphlpapi.h> > why those changes? They define some types used in the header. Not that all wouldn't compile without them, but when looking at the single file (like clangd does) these undefinedness. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba Gerrit-Change-Number: 489 Gerrit-PatchSet: 4 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Wed, 10 Jan 2024 15:47:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
