Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email )
Change subject: Allow trailing \r and \n in control channel message ...................................................................... Patch Set 3: Code-Review-1 (4 comments) Patchset: PS2: > I must say that I would feel better if we had a UT covering all this. […] Done Patchset: PS3: Thanks, addresses my concerns. However, does not actually build currently ;) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/672/comment/5483cbeb_14179e53 : PS2, Line 318: format_hex(BPTR(&buf), BLEN(&cmdbuf), 256, &gc)); > It is "not wrong today", but this sort of booby trap will come back and bite > us later - so this shou […] Done File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/672/comment/2df6966e_2cf72181 : PS3, Line 295: struct buffer cmdbuf = extract_command_buffer(buf, &gc); &buf -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e Gerrit-Change-Number: 672 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Comment-Date: Tue, 09 Jul 2024 16:13:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
