Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email )
Change subject: Allow trailing \r and \n in control channel message ...................................................................... Patch Set 4: Code-Review+2 (2 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/672/comment/48fff3e1_39fedac0 : PS2, Line 302: int buflen = (int)strlen(BSTR(&buf)) + 1; > While this is besser than the original, I find it still confusing to call > `strlen()` twice on the ve […] Done File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/672/comment/562bef0c_87a4f24d : PS3, Line 295: struct buffer cmdbuf = extract_command_buffer(buf, &gc); > &buf Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e Gerrit-Change-Number: 672 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Comment-Date: Wed, 10 Jul 2024 14:05:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
