Attention is currently required from: flichtenheld, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email )
Change subject: Adapt socket handling to support listening on multiple sockets ...................................................................... Patch Set 6: (18 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/434/comment/1d41d2b6_a8f7ac05 : PS5, Line 7: allow tcp/udp server to listen on multiple ports at the same time > For a change this fundamental this commit message is not enough. […] Done File src/openvpn/forward.h: http://gerrit.openvpn.net/c/openvpn/+/434/comment/777e4574_22f8383d : PS5, Line 239: void process_incoming_tun(struct context *c, struct link_socket *out_ls); > I think we have implicitly agreed to call those out_sock? Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/45aee7e6_1b3916da : PS5, Line 311: struct link_socket *ls); > let's stick with sock to be consistent? Done File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/25eddf8f_88da1d83 : PS5, Line 67: for (i = 0; i < c->c1.link_sockets_num; i++) > move declaration here. Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/52741d0c_ed1cfbf5 : PS5, Line 1500: out_ls); > this looks weird, why the additional line break? Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/c9729dd8_c23a63b3 : PS5, Line 2091: int i; > no Done File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/5db88ca1_62001647 : PS5, Line 2712: int i; > no Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/c4b1d0a7_caefad40 : PS5, Line 2726: int i; > no Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/d8bf560b_269e4c53 : PS5, Line 3809: int i; > no Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/3fbce72a_bc8f27b6 : PS5, Line 3830: int i; > no Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/96692862_fb70f0c5 : PS5, Line 3898: int i; > no Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/b06654d3_bd9889ea : PS5, Line 4059: int i; > no Done File src/openvpn/mtcp.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/324654a5_bfaf62d1 : PS5, Line 265: int status, i; > no Done File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/9eba0158_a12ada55 : PS5, Line 384: int i; > no Done File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/434/comment/b0f20aa4_59ddfbd1 : PS5, Line 133: bool did_open_context; > This must have been a rebase mistake, because: […] It was a rebase mistake indeed, so I removed this. File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/434/comment/a49234a5_d2525f23 : PS5, Line 348: link_socket_init_phase1(struct link_socket *sock, > hmm, no? […] Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/4d71982d_76aa122f : PS5, Line 1288: bool sockets_read_residual(const struct context *c); > please add minimal documentation Done File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/b48f0b7e_bcabdfe7 : PS5, Line 2239: #if defined (_WIN32) > ?? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/434?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia0a889e800f0b36aed770ee36e31afeec5df6084 Gerrit-Change-Number: 434 Gerrit-PatchSet: 6 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Thu, 17 Oct 2024 14:49:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
