Attention is currently required from: cron2, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/434?usp=email )
Change subject: Adapt socket handling to support listening on multiple sockets ...................................................................... Patch Set 10: (17 comments) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/69eb0e47_7a2fefdf : PS9, Line 4054: { > The `if()` should be outside and the `for()` inside - the condition does not > depend on `i`. Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/dff8a59a_21679821 : PS9, Line 4062: { > same thing. Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/c947a2ab_76ea9aa3 : PS9, Line 4786: get_link_socket_info(c)); > Should this be a per-socket thing? IPv4 vs. […] Made this a per-socket thing. http://gerrit.openvpn.net/c/openvpn/+/434/comment/b147968f_4b23f49c : PS9, Line 4991: &dest->gc); > if line length permits, can this be unwrapped? Done File src/openvpn/mtcp.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/45b85b7d_90856afd : PS9, Line 271: &c->c2.link_sockets[i]->ev_arg); > the diff looks as if there are tabs at the beginning of this line? Done File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/e1854ff0_37af4d92 : PS9, Line 388: sock); > please unwrap Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/a8787998_d8ad16d6 : PS9, Line 3336: { > I think this could be wrapped before `const unsigned int mpp_flags` Done File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/434/comment/9a778853_9ea799d9 : PS9, Line 1037: > another blank line Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/55bd01b2_52c753e9 : PS9, Line 1875: sock->bind_dev = o->bind_dev; > where did that go to? another rebase accident? *red flag* Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/6094ee4a_ac948ea1 : PS9, Line 1019: socket_descriptor_t sd; > we shouldn't delete blank lines unrelated to actual changes (minor nit) Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/e87a08aa_1f6e0dab : PS9, Line 1854: int mode) > please unwrap Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/36576466_961a732f : PS9, Line 1863: sock->remote_port = o->ce.remote_port; > not sure this change (remove the local variables `remote_host` and > `remote_port`) is a good thing as […] Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/9434c644_f418ccd8 : PS9, Line 1919: sock->proxy_dest_port = o->ce.remote_port; > this Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/f14a026f_c6ca2521 : PS9, Line 1924: > spurious blank line Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/8c99342c_c4d10f9f : PS9, Line 1931: sock->proxy_dest_port = o->ce.remote_port; > this Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/15fb1903_d0b82fdd : PS9, Line 1936: sock->remote_port = o->ce.remote_port; > and this Done http://gerrit.openvpn.net/c/openvpn/+/434/comment/066facc3_d851126b : PS9, Line 2301: /* Always restore the saved signal --register/throw_signal will handle priority */ > you lost a ` ` here after `--` (this is not a command line option > `--register`) Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/434?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia0a889e800f0b36aed770ee36e31afeec5df6084 Gerrit-Change-Number: 434 Gerrit-PatchSet: 10 Gerrit-Owner: ordex <a...@unstable.cc> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Mon, 30 Dec 2024 13:37:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
