Attention is currently required from: flichtenheld, mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/775?usp=email )
Change subject: t_server_null: forcibly kill misbehaving servers ...................................................................... Patch Set 5: Code-Review-2 (2 comments) Patchset: PS5: It fails to see "does the process still live?" due to `ps -p`, see comment at the corresponding line. Changing that to `RUN_SUDO kill -0 $SERVER_PID 2>/dev/null` yields the desired result (server hacked to maliciously ignore SIGTERM 2x) ``` Waiting for servers to exit ERROR: had to send SIGKILL to server with pid 10186! ERROR: had to send SIGKILL to server with pid 10189! FAIL: t_server_null.sh ``` now, while at it, we should actually print which server is "10186" and "10189" so it's easier to find the right log... File tests/t_server_null_server.sh: http://gerrit.openvpn.net/c/openvpn/+/775/comment/3af78b34_8263c5b3 : PS5, Line 100: ps -p "${SERVER_PID}" > /dev/null || break this does not work on systems where root processes are not visible to normal users, like "FreeBSD with `security.bsd.see_other_uids=0`" set. We've been here before - testing for "does the process still live?" needs to be done with `$RUN_SUDO kill -0 $SERVER_PID` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/775?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic0f98cd3b87a7b86e032e63167ac9036f7c08fcb Gerrit-Change-Number: 775 Gerrit-PatchSet: 5 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: mattock <sam...@openvpn.net> Gerrit-Comment-Date: Thu, 24 Oct 2024 18:41:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
