Attention is currently required from: flichtenheld, mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/775?usp=email )
Change subject: t_server_null: forcibly kill misbehaving servers ...................................................................... Patch Set 8: Code-Review-2 (4 comments) Patchset: PS8: getting closer File tests/t_server_null.sh: http://gerrit.openvpn.net/c/openvpn/+/775/comment/eede43c8_d60b792c : PS8, Line 72: wait remembering the pid of the t_server_null_server.sh job after launching (`server_sh_pid=$!`) and then calling `wait $server_sh_pid` will nicely deliver child program exit status in `$!`, without having to dance around with an extra file that needs to be created, rc-filed, tested-for. `wait` without a pid specified does not return child return code, which is somewhat annoying. File tests/t_server_null_server.sh: http://gerrit.openvpn.net/c/openvpn/+/775/comment/ea5470ba_cd74abb4 : PS3, Line 106: fi > I think we should make this a "test fail". […] Done File tests/t_server_null_server.sh: http://gerrit.openvpn.net/c/openvpn/+/775/comment/81b60a59_9f45dafb : PS8, Line 110: tail -n 20 "${t_server_null_logdir}/${SERVER_NAME}.log" this wants a `$RUN_SUDO` because root-owned logs are not readable otherwise (or we need to precreate them before openvpn startup)... ``` Waiting for servers to exit ERROR: had to send SIGKILL to server t_server_null_server-1194_udp with pid 23977! Tail of server log: tail: t_server_null-fbsd14bb.ov.greenie.net-20241025-105632/t_server_null_server-1194_udp.log: Permission denied ERROR: had to send SIGKILL to server t_server_null_server-1195_tcp with pid 23983! Tail of server log: tail: t_server_null-fbsd14bb.ov.greenie.net-20241025-105632/t_server_null_server-1195_tcp.log: Permission denied FAIL: t_server_null.sh ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/775?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic0f98cd3b87a7b86e032e63167ac9036f7c08fcb Gerrit-Change-Number: 775 Gerrit-PatchSet: 8 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: mattock <sam...@openvpn.net> Gerrit-Comment-Date: Fri, 25 Oct 2024 09:02:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
