Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/797?usp=email )
Change subject: Use XOR instead of concatenation for calculation of IV from implicit IV ...................................................................... Patch Set 2: (5 comments) Patchset: PS2: this is beyond my pay grade, but I found a few typos, I think... File src/openvpn/dco_freebsd.c: http://gerrit.openvpn.net/c/openvpn/+/797/comment/3336b2fb_a6fe95b6 : PS2, Line 398: /* FreeBSD uses the contact operation, need to skip the first 4 null concat? File src/openvpn/dco_linux.c: http://gerrit.openvpn.net/c/openvpn/+/797/comment/e129cd6f_c502323f : PS2, Line 588: /* First 4 zero bytes as the kernel does concat instead of XOR */ "skip" first 4 zero bytes? http://gerrit.openvpn.net/c/openvpn/+/797/comment/e717840e_40e36894 : PS2, Line 599: /* First 4 zero bytes as the kernel does concat instead of XOR */ as above File src/openvpn/dco_win.c: http://gerrit.openvpn.net/c/openvpn/+/797/comment/716de75f_9490d075 : PS2, Line 317: /* First 4 zero bytes as ovpn-dco-win does concat instead of XOR */ same comment as for Linux DCO, but no +4 here? confusing -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/797?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I74216d776d3e0a8dc987ec7b1671c8e8dcccdbd6 Gerrit-Change-Number: 797 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 11 Nov 2024 18:03:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
