Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/797?usp=email )
Change subject: Use XOR instead of concatenation for calculation of IV from implicit IV ...................................................................... Patch Set 3: (2 comments) File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/797/comment/aa9a760a_7b292150 : PS3, Line 435: const size_t packet_iv_len = packet_id_size(false); nit: since you are keeping this declaration here, I think it is more descriptive to use packet_iv_len in the following if block File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/797/comment/4af76cce_141b7572 : PS3, Line 1566: /* The first bytes of the IV are filled with the packet id */ is the extension to 96 bits implicit IV coming with a future patch? (i.e. DATA_V3 patchset?) Because elsewhere you described the implicit IV growing to 96 bits, but here it seems we are only accounting for the old format (with leading zeros) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/797?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I74216d776d3e0a8dc987ec7b1671c8e8dcccdbd6 Gerrit-Change-Number: 797 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Fri, 15 Nov 2024 09:29:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
