Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email )
Change subject: mudp.c: keep offset value when reset buffer ...................................................................... Patch Set 1: (3 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/814/comment/e9f0fd7c_69e29b82 : PS1, Line 7: mudp.c: keep offset value when reset buffer "resetting" File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/814/comment/fcb8e952_68fe37ee : PS1, Line 57: /* dco-win server requres prepend with sockaddr, so preserve offset */ "requires" http://gerrit.openvpn.net/c/openvpn/+/814/comment/dfafbbbe_9d592c2d : PS1, Line 58: buf_init(&c->c2.buffers->aux_buf, buf.offset); buf_init can fail (buf_reset_len cannot). Do we need error handling here? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I145573555aaace5e94774b5f977d032d3747ed72 Gerrit-Change-Number: 814 Gerrit-PatchSet: 1 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Fri, 22 Nov 2024 14:41:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
