Attention is currently required from: flichtenheld, plaisthos.

stipa has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/814?usp=email )

Change subject: mudp.c: keep offset value when reset buffer
......................................................................


Patch Set 1:

(3 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/814/comment/535895da_8fa8d201 :
PS1, Line 7: mudp.c: keep offset value when reset buffer
> "resetting"
Acknowledged


File src/openvpn/mudp.c:

http://gerrit.openvpn.net/c/openvpn/+/814/comment/c06e65ab_3f487764 :
PS1, Line 57:     /* dco-win server requres prepend with sockaddr, so preserve 
offset */
> "requires"
Acknowledged


http://gerrit.openvpn.net/c/openvpn/+/814/comment/7b8a5279_1096f128 :
PS1, Line 58:     buf_init(&c->c2.buffers->aux_buf, buf.offset);
> buf_init can fail (buf_reset_len cannot). […]
Will wrap it into ASSERT.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I145573555aaace5e94774b5f977d032d3747ed72
Gerrit-Change-Number: 814
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Fri, 22 Nov 2024 15:35:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to