Attention is currently required from: kallisti5, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/688?usp=email )
Change subject: Haiku: Add calls to manage routing table ...................................................................... Patch Set 3: Code-Review-1 (7 comments) File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/688/comment/cb24a5fc_d8a53a2e : PS3, Line 3940: sockfd = socket(AF_INET, SOCK_DGRAM, 0); Can be merged with the previous line? http://gerrit.openvpn.net/c/openvpn/+/688/comment/e8a07f51_932f4e4e : PS3, Line 3942: msg(M_INFO, "%s: Error opening socket for AF_INET", __func__); M_ERRNO? http://gerrit.openvpn.net/c/openvpn/+/688/comment/4b71cd90_2cc12dc0 : PS3, Line 3949: msg(M_INFO, "%s: Error getting routing table size", __func__); M_ERRNO? http://gerrit.openvpn.net/c/openvpn/+/688/comment/cdfe37bd_7ed2e6c0 : PS3, Line 3958: N Use `check_malloc_return`. http://gerrit.openvpn.net/c/openvpn/+/688/comment/2837f36b_f5691068 : PS3, Line 3976: strcpy(rgi->iface, interface->ifr_name); Should probably use `strcpynt` http://gerrit.openvpn.net/c/openvpn/+/688/comment/259f47d5_648923cf : PS3, Line 3979: int32 addressSize = 0; no CamelCase please. http://gerrit.openvpn.net/c/openvpn/+/688/comment/dfdc0992_8f8edb22 : PS3, Line 3990: } This seems to leak memory from the malloc? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/688?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1a22724f28c5cd47f6df178b49f44087d7c2b6fd Gerrit-Change-Number: 688 Gerrit-PatchSet: 3 Gerrit-Owner: kallisti5 <a...@terarocket.io> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: kallisti5 <a...@terarocket.io> Gerrit-Comment-Date: Tue, 26 Nov 2024 17:08:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
