Attention is currently required from: flichtenheld, plaisthos. kallisti5 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/688?usp=email )
Change subject: Haiku: Add calls to manage routing table ...................................................................... Patch Set 5: (8 comments) Patchset: PS5: Changes 99% done. One remaining. strncpy? Not sure what strcpynt is. File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/688/comment/b11d677f_d33d20c9 : PS3, Line 3940: sockfd = socket(AF_INET, SOCK_DGRAM, 0); > Can be merged with the previous line? Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/ad7dfc0e_82230690 : PS3, Line 3942: msg(M_INFO, "%s: Error opening socket for AF_INET", __func__); > M_ERRNO? Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/edd8c58c_a5545f1a : PS3, Line 3949: msg(M_INFO, "%s: Error getting routing table size", __func__); > M_ERRNO? Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/15117370_186fb3a1 : PS3, Line 3958: N > Use `check_malloc_return`. Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/c99a0ee5_6001d640 : PS3, Line 3976: strcpy(rgi->iface, interface->ifr_name); > Should probably use `strcpynt` strncpy? http://gerrit.openvpn.net/c/openvpn/+/688/comment/a9cb3152_0855c379 : PS3, Line 3979: int32 addressSize = 0; > no CamelCase please. Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/3a9f5015_6ae45d40 : PS3, Line 3990: } > This seems to leak memory from the malloc? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/688?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1a22724f28c5cd47f6df178b49f44087d7c2b6fd Gerrit-Change-Number: 688 Gerrit-PatchSet: 5 Gerrit-Owner: kallisti5 <a...@terarocket.io> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 26 Nov 2024 18:56:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
