Attention is currently required from: cron2, flichtenheld, plaisthos. kallisti5 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/688?usp=email )
Change subject: Haiku: Add calls to manage routing table ...................................................................... Patch Set 11: (10 comments) Patchset: PS10: All complete. I should note that the full functionality of these changes depends on https://review.haiku-os.org/c/haiku/+/8592 (tldr; we only accept "default" for the default gateway, while everyone else seems to also accept 0.0.0.0 / ::. Instead of hacking in "0.0.0.0 -> default" in the openvpn source code, I opted to add support for "0.0.0.0" as the default gw in the route command of Haiku) I'm planning on getting that change into the most recent stable release of Haiku as well to make sure openvpn works out of the box. File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/688/comment/6ac793fe_ff5b6200 : PS8, Line 1858: { > please remove this indentation level, it looks unnecessary. […] Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/e0159a17_04786e1d : PS8, Line 2350: { > same here Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/c21c4740_b10d021b : PS8, Line 2543: { > same here. […] I went ahead and added the IPv6 route addition code. Our IPv6 stack exists, and is baseline functional, but it's not well tested and has known faults (thus the priority was low) However, our routing all should work fine... so I went ahead and implemented the ipv6 route add call. http://gerrit.openvpn.net/c/openvpn/+/688/comment/ef8e2b2d_3b195cb1 : PS8, Line 3940: if (sockfd < 0) { > this is a style guide violation - normally, for first time submitters, I'd > fix that on the fly but s […] Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/0e55a08d_ab176494 : PS8, Line 3947: if (ioctl(sockfd, SIOCGRTSIZE, &config, sizeof(struct ifconf)) < 0) { > this Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/a3a35f3d_7632b680 : PS8, Line 3954: return; > we require to always have braces, even if it's a single statement […] Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/15fc33c0_b4d9d006 : PS8, Line 3961: if (ioctl(sockfd, SIOCGRTTABLE, &config, sizeof(struct ifconf)) < 0) { > bracket Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/eaf2eaa7_c865a3e5 : PS8, Line 3969: while (interface < end) { > bracket Done http://gerrit.openvpn.net/c/openvpn/+/688/comment/f5cf04fe_ffc728c3 : PS8, Line 3978: if (route.destination != NULL) > these need braces... Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/688?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1a22724f28c5cd47f6df178b49f44087d7c2b6fd Gerrit-Change-Number: 688 Gerrit-PatchSet: 11 Gerrit-Owner: kallisti5 <a...@terarocket.io> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 28 Nov 2024 15:14:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
