Attention is currently required from: cron2, flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/796?usp=email )
Change subject: Trigger renegotiation of data key if getting close to the AEAD usage limit ...................................................................... Patch Set 10: Code-Review-1 (4 comments) Patchset: PS10: I've pointed out a few more places where you could use uint. Let me know if this is excessive nitpicking. File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/796/comment/56ca9914_0cae7c14 : PS10, Line 355: int64_t This could be uint File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/796/comment/ca8aab0e_b7f91c98 : PS10, Line 134: static int64_t : tls_get_limit_aead(const char *ciphername) : { : int64_t limit = cipher_get_aead_limits(ciphername); : : if (limit == 0) : { : return 0; : } : : /* set limit to 7/8 of the limit so the renogiation can succeed before : * we go over the limit */ : limit = limit * 7/8; : : msg(D_SHOW_KEYS, "Note: AEAD cipher %s will be limited to a sum of %" : PRIi64 " for block and packets before renegotiation", : ciphername, limit); : return limit; : } This function could return uint File src/openvpn/ssl_common.h: http://gerrit.openvpn.net/c/openvpn/+/796/comment/166427ee_9749af9d : PS10, Line 338: int64_t aead_usage_limit; This could be uint -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/796?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I057f007577f10c6ac917ee4620ee3d2559187dc7 Gerrit-Change-Number: 796 Gerrit-PatchSet: 10 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: MaxF <m...@max-fillinger.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 03 Dec 2024 13:48:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
