Attention is currently required from: MaxF, cron2, plaisthos.

syzzer has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/796?usp=email )

Change subject: Trigger renegotiation of data key if getting close to the AEAD 
usage limit
......................................................................


Patch Set 13: Code-Review+1

(2 comments)

Patchset:

PS13:
Looks good conceptually. I don't have a dev/test setup available to actually do 
a full review, so sticking to +1.


File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/796/comment/5601c42a_7ba38f22 :
PS12, Line 149:         PRIi64 " for block and packets before renegotiation",
> The hard limit of 2**32-1 is still there. […]
Ahh, I didn't realize the hard limit arrived with the epoch patches. That's 
perfect.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/796?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I057f007577f10c6ac917ee4620ee3d2559187dc7
Gerrit-Change-Number: 796
Gerrit-PatchSet: 13
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: MaxF <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: syzzer <[email protected]>
Gerrit-CC: cron2 <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: MaxF <[email protected]>
Gerrit-Comment-Date: Thu, 12 Dec 2024 20:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <[email protected]>
Comment-In-Reply-To: syzzer <[email protected]>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to