Attention is currently required from: flichtenheld, mrbff, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/809?usp=email )
Change subject: PUSH_UPDATE: Added remove_option() and do_update(). ...................................................................... Patch Set 7: Code-Review-2 (2 comments) File src/openvpn/init.h: http://gerrit.openvpn.net/c/openvpn/+/809/comment/94a55af1_56ebeb0e : PS4, Line 89: bool do_update(struct context *c, unsigned int option_types_found); Doxygen File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/809/comment/3765b756_2ab72e4d : PS7, Line 3300: && (opt->routes->flags & RG_DEF1)) this gives me "access violation" on Windows, opt->routes is nullptr. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I507180d7397b6959844a30908010132bc3411067 Gerrit-Change-Number: 809 Gerrit-PatchSet: 7 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: mrbff <ma...@mandelbit.com> Gerrit-Comment-Date: Tue, 03 Dec 2024 14:42:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
