Attention is currently required from: flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/809?usp=email )
Change subject: PUSH_UPDATE: Added remove_option() and do_update(). ...................................................................... Patch Set 11: (1 comment) File src/openvpn/route.h: http://gerrit.openvpn.net/c/openvpn/+/809/comment/7dd177d3_7d6de585 : PS11, Line 325: destroy_routes_v4(struct route_list *rl, const struct tuntap *tt, > Apart from lacking comments, how does it differ from delete_routes()? > Couldn't we reuse existing fun […] The destroy_routes_vx are used to split the logic of delete_routes in v4 and v6 and also to delete the routes in the "options" struct. In most cases where delete_route functions are used it is correct not to delete the routes in the "options" struct so I simply created the functions I needed. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I507180d7397b6959844a30908010132bc3411067 Gerrit-Change-Number: 809 Gerrit-PatchSet: 11 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:14:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
