Attention is currently required from: flichtenheld, plaisthos, ralf_lici. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/844?usp=email )
Change subject: Fix float support in P2P topology ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: This looks like it should work (I do have a few nags) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/844/comment/54eabdc3_8b8edf10 : PS1, Line 1238: if (remote && (family == AF_INET || family == AF_INET6)) I'm not sure what *that* does? When can we ever have a `remote` and an family that is neither `AF_INET` nor `AF_INET6`? (If we're waiting for incoming data it can be `AF_UNSPEC`, but then we have no `remote`, no?) http://gerrit.openvpn.net/c/openvpn/+/844/comment/c48925bd_4bc7c300 : PS1, Line 1245: if (floated && c->c2.buf.len > 0) the GC seems only used inside here, and since this is a performance relevant function ("hot path", executed for each packet) we should not doing unneccessary work -> `gc_new(), gc_free()` can be inside the `if (floated)`. http://gerrit.openvpn.net/c/openvpn/+/844/comment/21341812_f18c537c : PS1, Line 1253: process_incoming_link_part2(c, lsi, orig_buf); should this be *inside* the `if()`? In the old code `_part2()` is unconditionally called always -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/844?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I806757a8c6f9a589665624f176391b5f7b87f581 Gerrit-Change-Number: 844 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici <r...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ralf_lici <r...@mandelbit.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 21:56:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
