Attention is currently required from: cron2, flichtenheld, plaisthos. ralf_lici has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/844?usp=email )
Change subject: Fix float support in P2P topology ...................................................................... Patch Set 1: (4 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/844/comment/a2f4224f_180af603 : PS1, Line 1238: if (remote && (family == AF_INET || family == AF_INET6)) > I'm not sure what *that* does? When can we ever have a `remote` and an > family that is neither `AF_I […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/844/comment/ed3d6af5_b5a33468 : PS1, Line 1245: if (floated && c->c2.buf.len > 0) > the GC seems only used inside here, and since this is a performance relevant > function ("hot path", e […] Definitely, I think I forgot to reorder this when I removed the other debugging prints I used for testing purposes. Acknowledged. http://gerrit.openvpn.net/c/openvpn/+/844/comment/34c401d6_00f96d38 : PS1, Line 1251: tls_update_remote_addr Tested the non-tls p2p configuration (`--secret`) and realized that this line obviously segfaults. Sorry for this, I will fix it on the next patch. http://gerrit.openvpn.net/c/openvpn/+/844/comment/ee561cd1_89c6d5cc : PS1, Line 1253: process_incoming_link_part2(c, lsi, orig_buf); > should this be *inside* the `if()`? In the old code `_part2()` is > unconditionally called always AFAICT the output of `_part1()` is correlated with `c->c2.buf.len` such that `buf.len` is always <= 0 if `_part1()` returns false (though the reverse isn't always true). Since `_part2()` processes a packet only if `buf.len > 0`, it seems safe to call `_part2()` only if `_part1()` returns true. However, as the current implementation works and I’m not entirely certain, I suggest leaving it as is unless there’s a strong reason to switch to conditional execution. What do you think? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/844?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I806757a8c6f9a589665624f176391b5f7b87f581 Gerrit-Change-Number: 844 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici <r...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Sat, 21 Dec 2024 15:23:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
