Attention is currently required from: its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/764?usp=email )
Change subject: Bind to multiple ipv4/ipv6 addresses ...................................................................... Patch Set 10: (4 comments) Patchset: PS10: some initial comments File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/4b14a43b_444e9460 : PS10, Line 331: * Return the io_wait() flags appropriate for any particular reason why this is moved up? File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/daecd6cc_2a7c62a8 : PS10, Line 1000: for (int j = 0; j < e->local_list->len; j++) not sure how useful that change is - we basically set the same environment variable `len` times, every time overwriting the previous one. http://gerrit.openvpn.net/c/openvpn/+/764/comment/62ecf583_fdc89a37 : PS10, Line 3833: if (!has_udp_in_local_list(o)) That's not really the right check - or the function is named badly. The check needs to be `if (has_tcp_...)` or `if (!has_only_udp_...)`, no? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/764?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I31bbf87e4e568021445c7512ecefadfd4a69b363 Gerrit-Change-Number: 764 Gerrit-PatchSet: 10 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Mon, 30 Dec 2024 19:28:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
