Attention is currently required from: cron2, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/764?usp=email )
Change subject: Bind to multiple ipv4/ipv6 addresses ...................................................................... Patch Set 11: (3 comments) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/28aa0c26_868ac69b : PS10, Line 331: * Return the io_wait() flags appropriate for > any particular reason why this is moved up? just a leftover. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/3d99bd65_c221426a : PS10, Line 1000: for (int j = 0; j < e->local_list->len; j++) > not sure how useful that change is - we basically set the same environment > variable `len` times, eve […] made another function to do this specifically for every local_entry, let me know if this is legal. http://gerrit.openvpn.net/c/openvpn/+/764/comment/9afa3ab7_df013376 : PS10, Line 3833: if (!has_udp_in_local_list(o)) > That's not really the right check - or the function is named badly. […] made another function has_tcp_in_local_list(), might be useful in some cases, also I moved this check little bit down to when we have at least one local_entry, again, let me know if this is legal -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/764?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I31bbf87e4e568021445c7512ecefadfd4a69b363 Gerrit-Change-Number: 764 Gerrit-PatchSet: 11 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Comment-Date: Thu, 09 Jan 2025 13:52:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
