Attention is currently required from: flichtenheld.

Hello flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/850?usp=email

to review the following change.


Change subject: fixup! Add methods to read/write packet ids for epoch data
......................................................................

fixup! Add methods to read/write packet ids for epoch data

Change-Id: Id1632e4e47f5a9019afecae60457634c4a3c4d31
---
M src/openvpn/packet_id.h
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/50/850/1

diff --git a/src/openvpn/packet_id.h b/src/openvpn/packet_id.h
index e78d912..9c0f464 100644
--- a/src/openvpn/packet_id.h
+++ b/src/openvpn/packet_id.h
@@ -336,7 +336,7 @@
 /**
  * Writes the packet ID containing both the epoch and the packet id to the
  * buffer specified by buf.
- * @param p         packed id send structure to use for the packet id
+ * @param p         packet id send structure to use for the packet id
  * @param epoch     epoch to write to the packet
  * @param buf       buffer to write the packet id/epoch to
  * @return          false if the packet id space is exhausted and cannot be 
written
@@ -347,7 +347,7 @@
 /**
  * Reads the packet ID containing both the epoch and the per-epoch counter
  * from the buf.  Will return 0 as epoch id if there is any error.
- * @param p       packet_id struct to popupulate with the on-wire counter
+ * @param p       packet_id struct to populate with the on-wire counter
  * @param buf     buffer to read the packet id from.
  * @return        0 for an error/invalid id, epoch otherwise
  */

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/850?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id1632e4e47f5a9019afecae60457634c4a3c4d31
Gerrit-Change-Number: 850
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to