Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/849?usp=email
to review the following change.
Change subject: fixup! Add methods to read/write packet ids for epoch data
......................................................................
fixup! Add methods to read/write packet ids for epoch data
Change-Id: Ie60a0a427ca810e28ab9049a8599510423f79bc1
---
M tests/unit_tests/openvpn/test_packet_id.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/49/849/1
diff --git a/tests/unit_tests/openvpn/test_packet_id.c
b/tests/unit_tests/openvpn/test_packet_id.c
index a24580b..312a6b3d 100644
--- a/tests/unit_tests/openvpn/test_packet_id.c
+++ b/tests/unit_tests/openvpn/test_packet_id.c
@@ -238,7 +238,8 @@
uint8_t expected_header_48[8] = { 0xff, 0xfe, 0xfa, 0x07, 0x9a, 0xb9,
0xd2, 0xe9};
assert_memory_equal(BPTR(&buf_48), expected_header_48, 8);
- /* test writing/checking the 48 bit overflow */
+ /* test writing/checking the 48 bit per epoch packet counter
+ * overflow */
data->pis.id = 0xfffffffffffe;
struct buffer buf_of = alloc_buf_gc(128, &data->gc);
assert_true(packet_id_write_epoch(&data->pis, 0xf00f, &buf_of));
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/849?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie60a0a427ca810e28ab9049a8599510423f79bc1
Gerrit-Change-Number: 849
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
