Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email )
Change subject: dns: support running up/down script with privsep ...................................................................... Patch Set 7: (1 comment) File src/openvpn/dns.c: http://gerrit.openvpn.net/c/openvpn/+/839/comment/6e128420_528a4795 : PS7, Line 709: ssize_t len = read(rfd, &status, sizeof(status)); > Do we need some kind of timeout handling here? Hm, that's a good thought. I'd rather implement the timeout in the script runner process, since the only source for an indefinite "hang" is the script itself. By handling this in the runner, we could also make sure that it is ready for the next request, i.e. unblocked. If we just implement the timeout here next time we need to run the script it will timeout again otherwise. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6b67e3a00dd84bf348b6af28115ee11138c3a111 Gerrit-Change-Number: 839 Gerrit-PatchSet: 7 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 20 Jan 2025 19:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
