Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email )
Change subject: dns: support running up/down script with privsep ...................................................................... Patch Set 8: (1 comment) File src/openvpn/dns.c: http://gerrit.openvpn.net/c/openvpn/+/839/comment/032ef1df_3b6026f8 : PS7, Line 709: ssize_t len = read(rfd, &status, sizeof(status)); > Hm, that's a good thought. […] So, after careful consideration I think it is doable to add a timeout mechanism to script calls, but I think if we decide to do that it should be done for all script hooks. Currently it is not done, and if a script hangs indefinitely openvpn is block indefinitely. I think accepting that is also a valid outcome, so we need to decide as a group which way to go. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6b67e3a00dd84bf348b6af28115ee11138c3a111 Gerrit-Change-Number: 839 Gerrit-PatchSet: 8 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 00:29:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: d12fk <he...@openvpn.net> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
