Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/873?usp=email )
Change subject: Print warnings/errors when numerical parameters cannot be parsed ...................................................................... Patch Set 1: Code-Review-2 (1 comment) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/873/comment/a064c05a_92fbd9c8 : PS1, Line 4939: if (i < 0 || endptr || i > INT_MAX) Should probably be *endptr? Basically we want to check that it is \0, right? t_server fails with: "Options error: Cannot parse argument '2' as non-negative integer" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/873?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de Gerrit-Change-Number: 873 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Tue, 21 Jan 2025 13:28:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
